Skip to content

fix: flaky k8s provider test#5608

Merged
guydc merged 1 commit intoenvoyproxy:mainfrom
shahar-h:fix-flaky-k8s-test
Mar 25, 2025
Merged

fix: flaky k8s provider test#5608
guydc merged 1 commit intoenvoyproxy:mainfrom
shahar-h:fix-flaky-k8s-test

Conversation

@shahar-h
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Fixes flaky k8s provider test by disabling health probe listener.

Which issue(s) this PR fixes:
Fixes #5601

Signed-off-by: Shahar Harari <shahar.harari@sap.com>
@shahar-h shahar-h requested a review from a team as a code owner March 25, 2025 14:34
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@arkodg arkodg requested review from a team March 25, 2025 14:45
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.27%. Comparing base (4f33df1) to head (6a72868).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5608      +/-   ##
==========================================
+ Coverage   65.25%   65.27%   +0.01%     
==========================================
  Files         213      213              
  Lines       34073    34073              
==========================================
+ Hits        22234    22240       +6     
+ Misses      10503    10500       -3     
+ Partials     1336     1333       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shahar-h
Copy link
Copy Markdown
Contributor Author

/retest

@guydc guydc merged commit a95c06f into envoyproxy:main Mar 25, 2025
25 checks passed
@shahar-h shahar-h deleted the fix-flaky-k8s-test branch March 25, 2025 17:34
lxie123 pushed a commit to lxie123/gateway that referenced this pull request Mar 26, 2025
Signed-off-by: Shahar Harari <shahar.harari@sap.com>
Signed-off-by: Ubuntu <lxie@k0rdent.dg30utm4mk2e3fblffod03krea.bx.internal.cloudapp.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky k8s provider test

3 participants